On Thu, Nov 24, 2011 at 12:45 AM, Thomas Krichel <krichel@openlib.org> wrote:
Ivan Kurmanov writes
Now -- by making Yes the default choice for exact matches. Not based on the relevance column, which is always zero in an environment without learning. This change is not compatible with your ACIS version.
I am not impressed. I trust that this will only affect the presentation? Or is this is the perl code? Could this not be fixed by introducing a configuration paremented?
To be honest, I'm not impressed either. Yes, the change is in presentation, two xslt files. Yes, it could be done more elegantly via a configuration parameter. But we a very short on time. aras@holda:~/dev/acis.r$ darcs diff -p "research/suggestions: back to showing the default choice based on status, not on relevance. incompatible with the learning, etc." | less would show you the diff of that change.
And there's a whole other bunch of incompatible changes, like switching back to HTML output in XSLT versus XHTML. And the backwards namespaces simplification: I have mostly eliminated the XHTML namespace use. I'm sorry about that, but I couldn't get some javascript processed otherwise. (Not sure if /adm/events javascript works on your installations, for example, and if it does -- how.)
I have never used /adm/events. But I am surprised it should be difficult to get this to work with a proper DOM approach.
You never used /adm/events, and that is fine. But Christian and I use it. And your change from HTML to XHTML broke it. I failed to find the way to make it work with xhtml output, without ugly constructs, that would render the javascript pieces unreadable. If you find it, i'm fine. (I just don't see any benefit in xhtml versus html to spend any more time on this.) -ivan