On Sat, Dec 17, 2011 at 12:30 AM, Christian Zimmermann <zimmermann@stlouisfed.org> wrote:
Looks good.
Does the way you implemented this actually require Javascript? It could be done without it, right?, as there is not total box.
It does require JavaScript even without the total box. Long story, but without it the form could delete an affiliation when the user have just tried to edit the shares. And for that to happen just this one simple thing has to happen: user enters an input box with share numbers and presses Enter. That submits the form in the same way, as if user clicked on a delete button of an affiliation. No way for the software on the server to tell the difference. So, client-side software comes to help.
Clicking on "saving shares" rebalances as desired.
good!
Also, I notice one cannot search for affiliation locations any more. Applies to live version as well.
This is something Thomas has removed in his version. I've put it back, except for search instructions. Do we need the instructions? -ivan
On Fri, 16 Dec 2011, Ivan Kurmanov wrote:
Christian,
Please review the first implementation of affiliation shares at http://ras.openlib.org/ . It is quite rough at SOME edges:
- shares are not exported to redif - no total box - no confirmation shown when an affiliation is deleted or added or when shares are modified - not well tested
With the Share column added the Delete button now depends on JavaScript in the browser. They won't work when/if javascript is disabled, but it should show a warning for that case.
-ivan
On Mon, Nov 21, 2011 at 11:58 AM, Ivan Kurmanov <duraley@gmail.com> wrote:
label next to it. For example, in this mockup I use "Share:" as the label: http://www.screencast.com/t/qza127hJ0e
Or we change the affiliations display to a table view and put those input boxes into a column, with the submit button below the column. http://www.screencast.com/t/cNotuQQJ8uc
I like this second one more. It clusters less the left hand side.
ok.
(We probably need the percent sign (%) near the input boxes, or in the column title?)
– What would the input box label or the column label be? – What label should the button have?
They are OK as in the mockup. But I suggest adding at the bottom of the column a "total" box, that adds up the shares, with a % sign. Javascript can add the shares live, as I have seen elsewhere.
Yes, and I like the idea.
Of course, what happens if someone does not have Javascript turned on?
It would simply not react to share changes, or will be empty at all.
User may change the numbers and submit the change by clicking the [Save share changes] button. Then we process the share values given and adjust it proportionally to a total of 100%. And we display the same screen with adjusted numbers and with the affiliations sorted in the order of decreasing share. Additionally, we show a confirmation message in the top part of the page, saying "The affiliation shares have been saved." or similar.
– Do we need such message? What text would you like to have there?
Confirmation is always good.
okay
If the user has opened the affiliations page, has modified the Share value for one or more affiliations, but then clicked on the [Delete] button of some other affiliation, his change to the share values is not saved. We may show a confirmation dialog if he wants to submit the form without saving the share value.
– What should be the confirmation dialog text then? "The share changes will not be saved. [Cancel] [OK]"
SOmething like "Please adjust shares after deletion"?
hmm.
– Or alternatively, we could save the shares even in this case. Save the shares AND delete the affiliation at the same time. Is this better?
– Anything else to clarify or to consider?
We may need an external link on or next to "Share" with some explanations. I propose:
"For multiple affiliations, please attribute a share to each. These will be used to determine the main affiliation and allocate ranking scores across affiliations. With affiliations in different regions or countries, your ranking scores will also be weighted accordingly."
okay.
I think that's enough for a first implementation, and then we would iron out the details, if any.
-ivan
-- Christian Zimmermann FIGUGEGL! Economic Research Federal Reserve Bank of St. Louis P.O. Box 442 St. Louis MO 63166-0442 USA http://ideas.repec.org/zimm/